feat(inbox): gate remaining inbox surfaces behind posthog-code-inbox flag#1840
Merged
joshsny merged 1 commit intoposthog-code/gate-inbox-behind-feature-flagfrom Apr 22, 2026
Conversation
…flag - Onboarding: filter out 'signals' step when flag is off - Settings: hide 'Signals' sidebar entry when flag is off - Welcome screen: hide 'Your signals inbox' feature bullet when flag is off - Keyboard shortcut: disable mod+i inbox hotkey when flag is off - Shortcuts sheet: hide inbox shortcut from list when flag is off
joshsny
merged commit 93c7a90
into
posthog-code/gate-inbox-behind-feature-flag
10 checks passed
Prompt To Fix All With AIThis is a comment left during a code review.
Path: apps/code/src/renderer/features/onboarding/components/WelcomeScreen.tsx
Line: 60
Comment:
**`CYCLE_START_DELAY_MS` ignores runtime feature count**
This constant is computed at module load using `ALL_FEATURES.length` (5), so when inbox is disabled the animation intro delay is 900 ms instead of the intended 800 ms (4 items × 100 ms + 400 ms). The difference is imperceptible, but the intent was clearly to match the number of rendered items. Consider deriving the delay inside the component from `features.length` instead.
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: apps/code/src/renderer/features/onboarding/components/WelcomeScreen.tsx
Line: 144-145
Comment:
**Prefer stable `id` as React list key**
Each item in `ALL_FEATURES` now has a dedicated `id` field. Using it as the list key is more robust than relying on the display title string.
```suggestion
<FeatureListItem
key={feature.id}
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "feat(inbox): gate remaining inbox surfac..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| const CYCLE_INTERVAL_MS = 2500; | ||
| const CYCLE_START_DELAY_MS = FEATURES.length * 100 + 400; | ||
| const CYCLE_START_DELAY_MS = ALL_FEATURES.length * 100 + 400; |
There was a problem hiding this comment.
CYCLE_START_DELAY_MS ignores runtime feature count
This constant is computed at module load using ALL_FEATURES.length (5), so when inbox is disabled the animation intro delay is 900 ms instead of the intended 800 ms (4 items × 100 ms + 400 ms). The difference is imperceptible, but the intent was clearly to match the number of rendered items. Consider deriving the delay inside the component from features.length instead.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/onboarding/components/WelcomeScreen.tsx
Line: 60
Comment:
**`CYCLE_START_DELAY_MS` ignores runtime feature count**
This constant is computed at module load using `ALL_FEATURES.length` (5), so when inbox is disabled the animation intro delay is 900 ms instead of the intended 800 ms (4 items × 100 ms + 400 ms). The difference is imperceptible, but the intent was clearly to match the number of rendered items. Consider deriving the delay inside the component from `features.length` instead.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
144
to
145
| <FeatureListItem | ||
| key={feature.title} |
There was a problem hiding this comment.
id as React list key
Each item in ALL_FEATURES now has a dedicated id field. Using it as the list key is more robust than relying on the display title string.
Suggested change
| <FeatureListItem | |
| key={feature.title} | |
| <FeatureListItem | |
| key={feature.id} |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/onboarding/components/WelcomeScreen.tsx
Line: 144-145
Comment:
**Prefer stable `id` as React list key**
Each item in `ALL_FEATURES` now has a dedicated `id` field. Using it as the list key is more robust than relying on the display title string.
```suggestion
<FeatureListItem
key={feature.id}
```
How can I resolve this? If you propose a fix, please make it concise.
joshsny
added a commit
that referenced
this pull request
Apr 22, 2026
…flag (#1840) Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #1828 gated the sidebar inbox item and inbox view behind the
posthog-code-inboxfeature flag, but several other surfaces still reference the inbox unconditionally. When the flag is off, users can still see signals-related UI in onboarding, settings, the welcome screen, and the keyboard shortcuts sheet — which is confusing and defeats the purpose of the kill switch.Stacks on #1828.
Changes
Gates all remaining inbox/signals surfaces behind
posthog-code-inbox:useOnboardingFlow.ts): Filters out the"signals"onboarding step when the flag is off, using the same pattern already used for"invite-code".SettingsDialog.tsx): Hides the "Signals" sidebar entry when the flag is off, using the same filter pattern already used for"plan-usage"/ billing.WelcomeScreen.tsx): Removes the "Your signals inbox" feature bullet from the welcome features list when the flag is off.GlobalEventHandlers.tsx): Disables themod+iinbox hotkey when the flag is off viaenabled: inboxEnabled.KeyboardShortcutsSheet.tsx): Hides the "Open inbox" shortcut from the keyboard shortcuts list when the flag is off.How did you test this?
@posthog/platform/@posthog/gitmodule resolution issues)Slack Thread